[Backport] deprecate materialization overrides from imported packages

[MichelleArk]

Backport of #9956 to 1.7

Solution

The easiest way to explain & review this PR is commit-by-commit:

• 4f5bbd5 and ad570bb: backport deprecation warning when materialization from package overrides built-in materialization (original PR: deprecate materialization overrides from imported packages #9971)
• 6e99dc4 simply updates the documentation link in the deprecation warning
• 455d817 brings the UserConfig -> ProjectFlags capability to 1.7 (original PR: Move UserConfig to dbt_project.yml and rename to ProjectFlags #9289)
• 9a1ae15 brings the ability to set project-only flags via ProjectFlags (original PR: Feature/source freshness hooks #9366)
• 1c40830 finally adds the require_explicit_package_overrides_for_builtin_materializations flag to ProjectFlags

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
• This PR includes type annotations for new and modified functions

No breaking interface changes. However, a deprecation warning will now be emitted for projects with flags defined in profiles.yml instead of dbt_project.yml. This PR introduces the capability to define flags in dbt_project.yml so I don't see an issue there.

[codecov]

Codecov Report

Attention: Patch coverage is 98.24561% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.67%. Comparing base (6a54a4c) to head (2080ae7).

Files	Patch %	Lines
core/dbt/config/project.py	97.56%	1 Missing ⚠️
core/dbt/contracts/graph/manifest.py	94.44%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##           1.7.latest    #9998      +/-   ##
==============================================
+ Coverage       86.64%   86.67%   +0.02%     
==============================================
  Files             179      179              
  Lines           26662    26722      +60     
==============================================
+ Hits            23102    23161      +59     
- Misses           3560     3561       +1     

Flag	Coverage Δ
integration	83.56% <92.98%> (+0.09%)	⬆️
unit	65.05% <88.59%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emmyoop]

looks good.

[ChenyuLInx]

Q: do we still support flags in profiles.yml?

[ChenyuLInx]

If no would this mean a potential breaking change?

[MichelleArk]

Yes! We fire a deprecation warning if flags are read from profiles.yml, but we still support it: https://github.com/dbt-labs/dbt-core/pull/9998/files#diff-8dc87da2257e24092820e0b29ea50eb16f002dd2c30b5879602b9311941858c0R820-R824

[ChenyuLInx]

Looks like all abstracted under read_project_flags?

[jtcohen6]

I'm totally cool with starting to fire this this deprecation warning in v1.7.x

As a general rule, I like the idea of backporting + patching deprecation warnings to actively supported versions, as soon as we decide behavior might change / be officially deprecated (with opt-out) in the next minor release, which could otherwise be multiple months away

[MichelleArk]

🎩 Did some final tophatting of this change using jaffle-shop! Here are the scenarios I tested:

• dbt run passes as usual
• dbt run when profiles.yml specifies config (but emits deprecation warning)
• dbt run when dbt_project.yml specifies flags + respects their configurations as expected
• custom materialization from root project works as expected
• added a 'default' materialization override for view in an installed package -> saw deprecation warning
• ^ + setting require_explicit_package_overrides_for_builtin_materializations: true -> no deprecation warning and confirmed materialization override not reached
• require_explicit_package_overrides_for_builtin_materializations: false` -> deprecation warning, materialization override occurred

[jtcohen6]

🎩 lgtm!