-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert from WritableManifest -> Manifest to represent deferred manifest internally #9544
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9544 +/- ##
==========================================
- Coverage 88.01% 88.01% -0.01%
==========================================
Files 178 178
Lines 22375 22413 +38
==========================================
+ Hits 19694 19727 +33
- Misses 2681 2686 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f0a2154
to
c794b35
Compare
… to resources before serialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
resolves #9567
Problem
Currently, PreviousState reads in a manifest artifact and uses the resulting WritableManifest object for state comparison downstream. With the artifacts restructuring happening as part of #9099, the WritableManifest class will contain 'resource' classes that don't have the requisite methods implemented.
Solution
RESOURCE_CLASS_TO_NODE_CLASS
to lookup resource class to node class, since resources are not aware of nodes.Checklist