Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unconditional calls to get_latest_version (#907) #949

Merged
merged 6 commits into from
Aug 28, 2018

Conversation

beckjake
Copy link
Contributor

I'm pretty sure that it really is this easy.

@drewbanin drewbanin self-requested a review August 24, 2018 14:27
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. LGTM when the tests pass

@beckjake
Copy link
Contributor Author

@drewbanin ok, this is actually fixed now, you can see the tricky bit...

@drewbanin
Copy link
Contributor

@beckjake I just tried running this locally and saw:

$ dbt --version
usage: dbt: data build tool [-h] [--version] [-d] [-S]
                            {init,clean,debug,deps,archive,run,compile,docs,seed,test}
                            ...
dbt: data build tool: error: too few arguments

@beckjake
Copy link
Contributor Author

@drewbanin that's really weird, on my machine I get:

$ dbt --version
installed version: 0.11.0-a1
   latest version: 0.10.2

Your version of dbt is ahead of the latest release!

@drewbanin
Copy link
Contributor

LGTM (again) when the tests pass!

@beckjake beckjake merged commit 6060146 into development Aug 28, 2018
@beckjake beckjake deleted the selectively-download-bumpversion branch August 28, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants