Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lock for git subduer #9019

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Fix lock for git subduer #9019

merged 6 commits into from
Nov 7, 2023

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Nov 7, 2023

#9000
Fix lock file for git with subdirectories.
Issue was that when writing out the lock file we didn't write out the complete information.

@cla-bot cla-bot bot added the cla:yes label Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6c1822f) 86.47% compared to head (e7108c9) 86.51%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9019      +/-   ##
==========================================
+ Coverage   86.47%   86.51%   +0.04%     
==========================================
  Files         179      179              
  Lines       26520    26532      +12     
==========================================
+ Hits        22933    22954      +21     
+ Misses       3587     3578       -9     
Flag Coverage Δ
integration 83.35% <90.47%> (+0.05%) ⬆️
unit 64.78% <52.38%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/deps/git.py 93.61% <100.00%> (+2.60%) ⬆️
core/dbt/deps/local.py 92.45% <100.00%> (+0.45%) ⬆️
core/dbt/deps/registry.py 97.36% <100.00%> (+0.07%) ⬆️
core/dbt/task/deps.py 94.28% <100.00%> (-0.05%) ⬇️
core/dbt/deps/base.py 89.00% <75.00%> (-0.70%) ⬇️
core/dbt/deps/tarball.py 79.06% <66.66%> (-0.94%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChenyuLInx ChenyuLInx marked this pull request as ready for review November 7, 2023 17:25
@ChenyuLInx ChenyuLInx requested a review from a team as a code owner November 7, 2023 17:25
@ChenyuLInx ChenyuLInx removed the request for review from MichelleArk November 7, 2023 17:46
Copy link
Contributor

@peterallenwebb peterallenwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add type annotations. Otherwise looks good.

@peterallenwebb peterallenwebb merged commit 01d481b into main Nov 7, 2023
51 checks passed
@peterallenwebb peterallenwebb deleted the cl/fix-deps-git-subdir branch November 7, 2023 18:58
github-actions bot pushed a commit that referenced this pull request Nov 7, 2023
* wip

* add tests

* changelog

* nits

* pr feedback

* nits

(cherry picked from commit 01d481b)
peterallenwebb pushed a commit that referenced this pull request Nov 7, 2023
* wip

* add tests

* changelog

* nits

* pr feedback

* nits

(cherry picked from commit 01d481b)

Co-authored-by: Chenyu Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants