-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lock for git subduer #9019
Fix lock for git subduer #9019
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
5f4d9c5
to
843a651
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9019 +/- ##
==========================================
+ Coverage 86.47% 86.51% +0.04%
==========================================
Files 179 179
Lines 26520 26532 +12
==========================================
+ Hits 22933 22954 +21
+ Misses 3587 3578 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add type annotations. Otherwise looks good.
* wip * add tests * changelog * nits * pr feedback * nits (cherry picked from commit 01d481b)
* wip * add tests * changelog * nits * pr feedback * nits (cherry picked from commit 01d481b) Co-authored-by: Chenyu Li <[email protected]>
#9000
Fix lock file for git with subdirectories.
Issue was that when writing out the lock file we didn't write out the complete information.