Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT-3144 Fix test edges type filter on Graph (#8696) #8716

Merged
merged 1 commit into from
Sep 26, 2023
Merged

CT-3144 Fix test edges type filter on Graph (#8696) #8716

merged 1 commit into from
Sep 26, 2023

Conversation

peterallenwebb
Copy link
Contributor

resolves #8692

Backports #8696 to 1.6.latest to repair a performance regression.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@renanleme @peterallenwebb
CT-3144 Fix test edges type filter on Graph (#8696)
97686e1 
* CT-3144 Fix test edges filter

* CT-3144 Add changelog

* CT-3144 Remove duplicated line

* CT-3144 Remove duplicated line

* CT-3144 Rename vars

* CT-3144 Update filter to use get_edge_data

* Trigger cla
@peterallenwebb peterallenwebb requested a review from a team as a code owner September 26, 2023 15:26
@cla-bot cla-bot bot added the cla:yes label Sep 26, 2023
@peterallenwebb peterallenwebb merged commit 5f897a0 into 1.6.latest Sep 26, 2023
56 checks passed
@peterallenwebb peterallenwebb deleted the backport/CT-3144-1.6 branch September 26, 2023 16:13
@aranke aranke mentioned this pull request Jul 12, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graciegoheen graciegoheen graciegoheen approved these changes

@QMalcolm QMalcolm Awaiting requested review from QMalcolm QMalcolm is a code owner automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
backport 1.6.latest cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterallenwebb @graciegoheen @renanleme