-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_numeric_values of the show test #8644
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #8644 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 175 175
Lines 25595 25595
=======================================
Hits 22156 22156
Misses 3439 3439
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 26c7675)
(cherry picked from commit 26c7675) Co-authored-by: Gerda Shank <[email protected]>
resolves #8470
Problem
The "test_numeric_values" test was checking for strings that were in or not in the logs. This is problematic, because as soon as something else accidentally had a 1.0 or 5.0 (such 1.06 seconds or something) the test would fail.
Solution
Check for more specific strings in show output, such as '"float_to_int_field": 1'.
Checklist