Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_numeric_values of the show test #8644

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Sep 13, 2023

resolves #8470

Problem

The "test_numeric_values" test was checking for strings that were in or not in the logs. This is problematic, because as soon as something else accidentally had a 1.0 or 5.0 (such 1.06 seconds or something) the test would fail.

Solution

Check for more specific strings in show output, such as '"float_to_int_field": 1'.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner September 13, 2023 18:21
@gshank gshank requested a review from emmyoop September 13, 2023 18:21
@cla-bot cla-bot bot added the cla:yes label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8aaed0e) 86.56% compared to head (3d116b3) 86.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8644   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files         175      175           
  Lines       25595    25595           
=======================================
  Hits        22156    22156           
  Misses       3439     3439           
Flag Coverage Δ
integration 83.35% <ø> (ø)
unit 65.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gshank gshank merged commit 26c7675 into main Sep 13, 2023
50 checks passed
@gshank gshank deleted the 8470-numeric_flaky_test branch September 13, 2023 19:38
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
gshank added a commit that referenced this pull request Sep 13, 2023
(cherry picked from commit 26c7675)

Co-authored-by: Gerda Shank <[email protected]>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3019] TestShow::test_numeric_values, TestShow::test_numeric_values_with_nulls are flaky
2 participants