-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix using project-dir with list command and path selector #8388
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8388 +/- ##
==========================================
+ Coverage 86.29% 86.36% +0.07%
==========================================
Files 174 174
Lines 25529 25543 +14
==========================================
+ Hits 22030 22060 +30
+ Misses 3499 3483 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
As an aside, I wasn't aware of these globals 😂 Adding more things to my hit list 👀
(cherry picked from commit 048553d)
(cherry picked from commit 048553d)
) (cherry picked from commit 048553d) Co-authored-by: Gerda Shank <[email protected]>
) (cherry picked from commit 048553d) Co-authored-by: Gerda Shank <[email protected]>
resolves #8385
Problem
We changed the way we access the contextvar for project_root in #7949, but also needed to add the contextvar to the run method of the list command.
Checklist