Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using project-dir with list command and path selector #8388

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Aug 14, 2023

resolves #8385

Problem

We changed the way we access the contextvar for project_root in #7949, but also needed to add the contextvar to the run method of the list command.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner August 14, 2023 19:01
@gshank gshank requested a review from ChenyuLInx August 14, 2023 19:01
@cla-bot cla-bot bot added the cla:yes label Aug 14, 2023
@gshank gshank requested review from peterallenwebb, emmyoop and QMalcolm and removed request for ChenyuLInx August 14, 2023 19:02
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #8388 (f7c686d) into main (b7aee3f) will increase coverage by 0.07%.
Report is 5 commits behind head on main.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main    #8388      +/-   ##
==========================================
+ Coverage   86.29%   86.36%   +0.07%     
==========================================
  Files         174      174              
  Lines       25529    25543      +14     
==========================================
+ Hits        22030    22060      +30     
+ Misses       3499     3483      -16     
Flag Coverage Δ
integration 83.09% <92.85%> (-0.03%) ⬇️
unit 65.23% <7.14%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/task/list.py 88.69% <92.85%> (+0.20%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

As an aside, I wasn't aware of these globals 😂 Adding more things to my hit list 👀

@gshank gshank merged commit 048553d into main Aug 16, 2023
54 checks passed
@gshank gshank deleted the ct-2970-project_dir_with_list branch August 16, 2023 14:39
github-actions bot pushed a commit that referenced this pull request Aug 16, 2023
github-actions bot pushed a commit that referenced this pull request Aug 16, 2023
gshank added a commit that referenced this pull request Aug 16, 2023
gshank added a commit that referenced this pull request Aug 16, 2023
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2970] [Regression] Fix path: selector with --project-dir for dbt list
2 participants