Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SemanticModel node to match DSI 0.1.0dev3 protocols #7848

Merged
merged 10 commits into from
Jun 13, 2023
Merged

Update SemanticModel node to match DSI 0.1.0dev3 protocols #7848

merged 10 commits into from
Jun 13, 2023

Commits on Jun 9, 2023

  1. Add tests to ensure our semantic layer nodes satisfy the DSI protocols 

    These tests create runtime checkable versions of the protocols defined in
DSI. Thus we can instantiate instances of our semantic layer nodes and
use `isinstance` to check that they satisfy the protocol. These `runtime_checkable`
versions of the protocols should only exist in testing and should never
be used in the actual package code.
    @QMalcolm
    QMalcolm committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    1f2eec1 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Update the Dimension object of SemanticModel node to match DSI pr… 

    …otocol
    @QMalcolm
    QMalcolm committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    612a01b View commit details
    Browse the repository at this point in the history

  2. Make UnparsedDimension more strict and update schema readers accord… 

    …ingly
    @QMalcolm
    QMalcolm committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    cd7099d View commit details
    Browse the repository at this point in the history

  3. Update the Entity object of SemanticModel node to match DSI protocol

    @QMalcolm
    QMalcolm committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    185e3fc View commit details
    Browse the repository at this point in the history

  4. Make UnparsedEntity more strict and update schema readers accordingly

    @QMalcolm
    QMalcolm committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    5007e2c View commit details
    Browse the repository at this point in the history

  5. Update the Measure object of SemanticModel node to match DSI prot… 

    …ocol
    @QMalcolm
    QMalcolm committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    467d993 View commit details
    Browse the repository at this point in the history

  6. Make UnparsedMeasure more strict and update schema readers accordingly

    @QMalcolm
    QMalcolm committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    28b6dab View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Update the SemanticModel node to match DSI protocol 

    A lot of the additions are helper functions which we don't actually
use on core. This is a known issue. We're in the process of removing
a fair number of them from the DSI protocol spec. However, in the mean
time we need to implement them to satisfy the protocol unfortunately.
    @QMalcolm
    QMalcolm committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d6809a9 View commit details
    Browse the repository at this point in the history

  2. Make UnparsedSemanticModel more strict and update schema readers ac… 

    …cordingly
    @QMalcolm
    QMalcolm committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    69ce4a6 View commit details
    Browse the repository at this point in the history

  3. Changie entry for updating SemanticModel node

    @QMalcolm
    QMalcolm committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f9ac0e1 View commit details
    Browse the repository at this point in the history