fix #7413: inject sql header in query for show #7568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranke
requested review from
iknox-fa,
emmyoop and
VersusFacit
and removed request for
a team
aranke
requested review from
stu-k
and removed request for
emmyoop and
VersusFacit
iknox-fa
reviewed
May 9, 2023
| @@ -23,6 +23,11 @@ def execute(self, compiled_node, manifest): | |||
| # Allow passing in -1 (or any negative number) to get all rows | |||
| limit = None if self.config.args.limit < 0 else self.config.args.limit | |||
|
|
|||
| if "sql_header" in compiled_node.unrendered_config: | |||
| compiled_node.compiled_code = ( | |||
| compiled_node.unrendered_config["sql_header"] + compiled_node.compiled_code | |||
There was a problem hiding this comment.
Almost certainly a premature optimization, but it's worth pointing out that string concatenation with the + operator is a bit inefficient.
ERm.. if those are strings. I assume they are at this point in the compilation process.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7413
Description
Checklist
changie newto create a changelog entry