Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

active project > local project in ConfiguredVar #7441

Merged
merged 3 commits into from
Apr 28, 2023
Merged

active project > local project in ConfiguredVar #7441

merged 3 commits into from
Apr 28, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Apr 23, 2023 •
edited
Loading

resolves #6705

Description

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
    • (I've sanity checked the new test fails on main)
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@cla-bot cla-bot bot added the cla:yes label Apr 23, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk marked this pull request as ready for review April 28, 2023 12:44
@MichelleArk MichelleArk requested review from a team as code owners April 28, 2023 12:44
gshank
gshank approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice neat solution.

@MichelleArk MichelleArk merged commit a7eb89d into main Apr 28, 2023
@MichelleArk MichelleArk deleted the 6705/fix-var-precedence-in-configs branch April 28, 2023 20:17
@aranke aranke mentioned this pull request May 9, 2023
Closed
6 tasks
This was referenced Jun 19, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshank gshank gshank approved these changes

@ChenyuLInx ChenyuLInx Awaiting requested review from ChenyuLInx ChenyuLInx was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1888] [Bug] Package project yml configs overriding root project configs when used in other yml files
2 participants
@MichelleArk @gshank