Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groupable node partial parsing, raise DbtReferenceError in RuntimeRefResolver #7438

Merged
merged 5 commits into from
Apr 25, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Apr 22, 2023

resolves #7437

Description

Currently, modifying a private node's "group" property does not schedule its referencing nodes for re-parsing. This can lead to a scenario where a node that should not be ref-able because of its access and group settings is refable during execution. This change fixes the partial parsing issue, and raises DbtReferenceError during execution (RuntimeRefResolver) out of an abundance of caution.

Checklist

@cla-bot cla-bot bot added the cla:yes label Apr 22, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk changed the title raise DbtReferenceError in RuntimeResolver Fix groupable node partial parsing, raise DbtReferenceError in RuntimeResolver Apr 24, 2023
@MichelleArk MichelleArk changed the title Fix groupable node partial parsing, raise DbtReferenceError in RuntimeResolver Fix groupable node partial parsing, raise DbtReferenceError in RuntimeRefResolver Apr 24, 2023
@MichelleArk MichelleArk marked this pull request as ready for review April 24, 2023 21:12
@MichelleArk MichelleArk requested review from a team as code owners April 24, 2023 21:12
@MichelleArk MichelleArk merged commit 9874f9e into main Apr 25, 2023
@MichelleArk MichelleArk deleted the dbt-ref-error-runtime branch April 25, 2023 15:09
@github-actions
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-7438-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9874f9e00417aba05273417d2a31371badd15bb5
# Push it to GitHub
git push --set-upstream origin backport-7438-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-7438-to-1.5.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2464] [Bug] DbtReferenceError again at runtime
3 participants