-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix groupable node partial parsing, raise DbtReferenceError in RuntimeRefResolver #7438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
MichelleArk
changed the title
raise DbtReferenceError in RuntimeResolver
Fix groupable node partial parsing, raise DbtReferenceError in RuntimeResolver
Apr 24, 2023
MichelleArk
changed the title
Fix groupable node partial parsing, raise DbtReferenceError in RuntimeResolver
Fix groupable node partial parsing, raise DbtReferenceError in RuntimeRefResolver
Apr 24, 2023
gshank
approved these changes
Apr 24, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-7438-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9874f9e00417aba05273417d2a31371badd15bb5
# Push it to GitHub
git push --set-upstream origin backport-7438-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest Then, create a pull request where the |
MichelleArk
added a commit
that referenced
this pull request
Apr 25, 2023
…eRefResolver (#7438) (#7461) (cherry picked from commit 9874f9e) Co-authored-by: Michelle Ark <[email protected]>
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7437
Description
Currently, modifying a private node's "group" property does not schedule its referencing nodes for re-parsing. This can lead to a scenario where a node that should not be ref-able because of its access and group settings is refable during execution. This change fixes the partial parsing issue, and raises DbtReferenceError during execution (RuntimeRefResolver) out of an abundance of caution.
Checklist
changie new
to create a changelog entry