Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloud-artifacts as codeowners of /schemas/dbt #7406

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

MichelleArk
Copy link
Contributor

resolves N/A

Description

Checklist

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Apr 18, 2023
@cla-bot cla-bot bot added the cla:yes label Apr 18, 2023

### ARTIFACTS

/schemas/dbt @dbt-labs/cloud-artifacts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the GH docs:

Users and teams must have explicit write access to the repository, even if the team's members already have access.

@leahwicz - are we okay granting write access to @dbt-labs/cloud-artifacts, assuming they don't have it already?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that is fine. We have PR reviews enforced so its not like an accidental commit can be pushed

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-term nit: this should be a CODENOTIFY file instead, so we're not blocked on the Cloud Artifacts review?

https://about.sourcegraph.com/blog/a-different-way-to-think-about-code-ownership


### ARTIFACTS

/schemas/dbt @dbt-labs/cloud-artifacts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that is fine. We have PR reviews enforced so its not like an accidental commit can be pushed

@MichelleArk MichelleArk self-assigned this Apr 19, 2023
@MichelleArk
Copy link
Contributor Author

@aranke - I don't believe this will block merging on code review from Cloud Artifacts based on the behaviour I've been seeing for changes to files owned by existing codeowners defined.

Here's a recent example that modified core/dbt/adapters/base/impl.py, tagged Core - Adapters as codeowners, but did not require an approval to merge: #7307

I'll create a test PR to confirm the behaviour once this is merged though!

@MichelleArk MichelleArk merged commit f5aea19 into main Apr 20, 2023
@MichelleArk MichelleArk deleted the add-ca-to-codeowners branch April 20, 2023 16:01
@aranke aranke mentioned this pull request May 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants