Persist timing info for failed nodes #7353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu-k
requested review from
ChenyuLInx,
peterallenwebb,
aranke,
a team and
gshank
and removed request for
a team and
peterallenwebb
aranke
reviewed
Apr 21, 2023
|
|
||
| def test_timing_exists(self, project): | ||
| results = run_dbt(["run"]) | ||
| assert results.results[0].timing |
There was a problem hiding this comment.
I think you want to do something like this:
for result in results.results:
assert isinstance(result, TimingInfo)There was a problem hiding this comment.
results.results is a list of RunResults, not TimingInfo. RunResult has a timing attribute on it which is a list of TimingInfos. What I'm doing here is asserting that this list of TimingInfos is not empty.
There should however only ever be one result in results.results since only one model is run for each of these tests, so I will add an assertion for that.
|
Go @stu-k :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5476
Description
Since python's context managers
__exit__method still runs if the code they wrap throws an exception, added a callback to thecollect_timing_infocontext manager to handle persisting the timing info for failed nodes toctx.timing.Checklist
changie newto create a changelog entry