Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3.latest] More ergonomic profile name handling #6199

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 2, 2022

Backport 77dfec7 from #6157.

@github-actions github-actions bot requested a review from a team as a code owner November 2, 2022 18:37
@github-actions github-actions bot requested a review from emmyoop November 2, 2022 18:37
@cla-bot cla-bot bot added the cla:yes label Nov 2, 2022
@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 2, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@iknox-fa iknox-fa added the Skip Changelog Skips GHA to check for changelog file label Nov 2, 2022
@emmyoop
Copy link
Member

emmyoop commented Nov 3, 2022

Close/reopen to trigger tests

@emmyoop emmyoop closed this Nov 3, 2022
@emmyoop emmyoop reopened this Nov 3, 2022
@emmyoop
Copy link
Member

emmyoop commented Nov 3, 2022

Failing due to pending changes in #6205

@leahwicz
Copy link
Contributor

leahwicz commented Nov 3, 2022

We need to wait for the code coverage fix to get in and then we can merge this

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and the blocker PR has been merged

@ChenyuLInx ChenyuLInx merged commit 2d1215e into 1.3.latest Nov 4, 2022
@ChenyuLInx ChenyuLInx deleted the backport-6157-to-1.3.latest branch November 4, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants