-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add optional shorthand to full refresh command #5879
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Personally, I like |
I would be happy with just updating one of the existing tests/functional tests that do "--full-refresh" with the new shortcut, such as tests/functional/materializations/test_runtime_materialization.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing stands out 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
resolves #5878
Description
Adds an optional shorthand for the
--full-refresh
flag!dbt build -fr
for an incremental model passes:and acts as expected:
Opening as a draft for now, assuming I need some testing here, but didn't find a test that quite looked like the right place at first glance!
Checklist
changie new
to create a changelog entry