Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendlier migrations happy customers #5821

Closed
wants to merge 2 commits into from

Conversation

callum-mcdata
Copy link
Contributor

Addresses #5807

Description

Following the helpful direction in @jtcohen6's gist, this DRAFT PR WHICH SHOULD NOT BE MERGED OR EVEN JUDGED, maps the old attributes in the manifest to the new ones and overwrites the expression metric type to derived.

What it is currently missing is some form of warn message at compile. I will need to add that before I can start addressing any weaknesses it may be missing in the tests.

I've tested this in a local branch and on a test dbt project to confirm that the manifest produced does look correct even with the old metric spec.

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 13, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@jtcohen6
Copy link
Contributor

@callum-mcdata I completely missed seeing this... check out #5825!

@jtcohen6
Copy link
Contributor

Closed in favor of #5825

@jtcohen6 jtcohen6 closed this Sep 16, 2022
@callum-mcdata callum-mcdata deleted the friendlier_migrations_happy_customers branch January 17, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants