Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert default selectors tests to pytest #5820

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Convert default selectors tests to pytest #5820

merged 2 commits into from
Sep 13, 2022

Conversation

stu-k
Copy link
Contributor

@stu-k stu-k commented Sep 12, 2022

resolves #5728

Description

Converted default selector tests.

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 12, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@stu-k stu-k marked this pull request as ready for review September 12, 2022 18:48
@stu-k stu-k requested a review from a team as a code owner September 12, 2022 18:48
leahwicz
leahwicz approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@leahwicz leahwicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stu-k stu-k merged commit 7da7c2d into main Sep 13, 2022
@stu-k stu-k deleted the ct-1097/convert-default-selectors-test branch September 13, 2022 16:47
josephberni pushed a commit to Gousto/dbt-core that referenced this pull request Sep 16, 2022
@stu-k @josephberni
Convert default selectors tests to pytest (dbt-labs#5820)
d3dd728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahwicz leahwicz leahwicz approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit was automatically assigned from dbt-labs/core-group

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt colin-rogers-dbt was automatically assigned from dbt-labs/core-group

@iknox-fa iknox-fa Awaiting requested review from iknox-fa

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1097] 073_default_selectors_tests
2 participants
@stu-k @leahwicz