Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove key as reserved keyword from test_bool_or #5818

Merged
merged 2 commits into from
Sep 15, 2022
Merged

remove key as reserved keyword from test_bool_or #5818

merged 2 commits into from
Sep 15, 2022

Conversation

sdebruyn
Copy link
Contributor

@sdebruyn sdebruyn commented Sep 12, 2022 •
edited
Loading

resolves #5817

Description

Use key_column instead of key in the test fixture since that would not be a reserved keyword

Checklist

@sdebruyn sdebruyn requested a review from a team as a code owner September 12, 2022 17:03
@cla-bot cla-bot bot added the cla:yes label Sep 12, 2022
@sdebruyn sdebruyn requested a review from a team as a code owner September 12, 2022 17:04
@sdebruyn sdebruyn requested a review from stu-k September 12, 2022 17:04
@jtcohen6 jtcohen6 added Team:Adapters Issues designated for the adapter area of the code ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Sep 13, 2022
stu-k
stu-k approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@stu-k stu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out 👍

@stu-k stu-k merged commit b98af4c into dbt-labs:main Sep 15, 2022
josephberni pushed a commit to Gousto/dbt-core that referenced this pull request Sep 16, 2022
@sdebruyn @josephberni
remove key as reserved keyword from test_bool_or (dbt-labs#5818)
85bdcfb
@shiyuhang0
Copy link

Happy to see this pr, so I need not to rewrite model like this :)

calculate as (
    select
        `key`,
        {{ bool_or('val1 = val2') }} as value
    from data
    group by `key`
)

@shiyuhang0 shiyuhang0 mentioned this pull request Nov 25, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stu-k stu-k stu-k approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit was automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering Team:Adapters Issues designated for the adapter area of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1154] [Bug] Adapter test bool_or contains reserved keyword
4 participants
@sdebruyn @shiyuhang0 @stu-k @jtcohen6