Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple args for ref and source #5635

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

ChenyuLInx
Copy link
Contributor

resolves #5634

Description

fix for multi level source/ref

Checklist

@ChenyuLInx ChenyuLInx requested a review from a team August 9, 2022 21:48
@ChenyuLInx ChenyuLInx requested a review from a team as a code owner August 9, 2022 21:48
@cla-bot cla-bot bot added the cla:yes label Aug 9, 2022
@ChenyuLInx ChenyuLInx marked this pull request as draft August 9, 2022 21:48
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@ChenyuLInx
Copy link
Contributor Author

ChenyuLInx commented Aug 9, 2022

TODO: add a test
Update: Done

@ChenyuLInx ChenyuLInx marked this pull request as ready for review August 16, 2022 22:35
@ChenyuLInx ChenyuLInx requested a review from a team as a code owner August 16, 2022 22:35
@@ -16,27 +17,64 @@ def model(dbt, _):
materialized='table',
)
df = dbt.ref("my_sql_model")
df2 = dbt.source('test_source', 'test_table')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will automatically run across places, tested locally in dbt-snowflake

@ChenyuLInx ChenyuLInx requested a review from gshank August 17, 2022 21:07
@ChenyuLInx ChenyuLInx merged commit a9e71b3 into main Aug 17, 2022
@ChenyuLInx ChenyuLInx deleted the python_model_ref_source_fix branch August 17, 2022 21:13
VersusFacit pushed a commit that referenced this pull request Sep 5, 2022
* fix multiple args for ref and source

* add test for support multi part ref and source
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
* fix multiple args for ref and source

* add test for support multi part ref and source
josephberni pushed a commit to Gousto/dbt-core that referenced this pull request Sep 16, 2022
* fix multiple args for ref and source

* add test for support multi part ref and source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1020] [Bug] In python models, dbt.source, dbt.ref doesn't work with multi part names
2 participants