-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix multiple args for ref and source #5635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
TODO: add a test |
ChenyuLInx
commented
Aug 16, 2022
@@ -16,27 +17,64 @@ def model(dbt, _): | |||
materialized='table', | |||
) | |||
df = dbt.ref("my_sql_model") | |||
df2 = dbt.source('test_source', 'test_table') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test will automatically run across places, tested locally in dbt-snowflake
gshank
approved these changes
Aug 17, 2022
VersusFacit
pushed a commit
that referenced
this pull request
Sep 5, 2022
* fix multiple args for ref and source * add test for support multi part ref and source
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* fix multiple args for ref and source * add test for support multi part ref and source
josephberni
pushed a commit
to Gousto/dbt-core
that referenced
this pull request
Sep 16, 2022
* fix multiple args for ref and source * add test for support multi part ref and source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5634
Description
fix for multi level source/ref
Checklist
changie new
to create a changelog entry