Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert to reusable action #5565

Merged
merged 17 commits into from
Aug 3, 2022
Merged

convert to reusable action #5565

merged 17 commits into from
Aug 3, 2022

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jul 27, 2022

resolves #5501

Description

Convert to use reusable action

Related PR in dbt-labs/actions repo: dbt-labs/actions#23

  • Fix branch name
  • any better names?

Checklist

@cla-bot cla-bot bot added the cla:yes label Jul 27, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop added Skip Changelog Skips GHA to check for changelog file and removed Skip Changelog Skips GHA to check for changelog file labels Jul 28, 2022
@emmyoop emmyoop closed this Jul 28, 2022
@emmyoop emmyoop reopened this Jul 28, 2022
@emmyoop emmyoop added Skip Changelog Skips GHA to check for changelog file and removed Skip Changelog Skips GHA to check for changelog file labels Jul 28, 2022
@emmyoop emmyoop closed this Jul 28, 2022
@emmyoop emmyoop reopened this Jul 28, 2022
@emmyoop emmyoop marked this pull request as ready for review July 28, 2022 20:10
@emmyoop emmyoop requested a review from leahwicz as a code owner July 28, 2022 20:10
@emmyoop emmyoop marked this pull request as draft July 28, 2022 20:10
@emmyoop emmyoop marked this pull request as ready for review July 28, 2022 20:16
uses: actions/github-script@v6
with:
script: core.setFailed('Changelog entry required to merge.')
uses: dbt-labs/actions/.github/workflows/changelog-check.yml@er/changelog-check
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to implement this change once dbt-labs/actions#23 gets merged in

Suggested change
uses: dbt-labs/actions/.github/workflows/changelog-check.yml@er/changelog-check
uses: dbt-labs/actions/.github/workflows/changelog-check.yml@main

@emmyoop emmyoop requested a review from McKnight-42 July 28, 2022 20:24
@emmyoop emmyoop added dependencies Changes to the version of dbt dependencies and removed dependencies Changes to the version of dbt dependencies Skip Changelog Skips GHA to check for changelog file labels Aug 1, 2022
@emmyoop emmyoop requested a review from a team as a code owner August 1, 2022 19:38
@emmyoop emmyoop added the dependencies Changes to the version of dbt dependencies label Aug 1, 2022
@emmyoop emmyoop removed the dependencies Changes to the version of dbt dependencies label Aug 1, 2022
Copy link
Contributor

@stu-k stu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out 👍

@emmyoop emmyoop force-pushed the er/ct-872-resusable-changie branch from 609a04c to 5b97ca7 Compare August 2, 2022 14:12
@emmyoop emmyoop added Skip Changelog Skips GHA to check for changelog file and removed Skip Changelog Skips GHA to check for changelog file labels Aug 2, 2022
@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Aug 2, 2022
@emmyoop emmyoop merged commit 40b55ed into main Aug 3, 2022
@emmyoop emmyoop deleted the er/ct-872-resusable-changie branch August 3, 2022 16:33
VersusFacit pushed a commit that referenced this pull request Sep 5, 2022
* convert to reusable action

* fix branch name

* reimplemented changelog

* update to use workflow

* fix typo

* move def

* inherit secrets

* send in comment/label

* specify GITHUB_TOKEN

* Add automated changelog yaml from template for bot PR

* Delete Dependency-20220801-193810.yaml

* Add automated changelog yaml from template for bot PR

* remove dummy changelog

* remove token

* rename file

* point to main

Co-authored-by: Github Build Bot <[email protected]>
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
* convert to reusable action

* fix branch name

* reimplemented changelog

* update to use workflow

* fix typo

* move def

* inherit secrets

* send in comment/label

* specify GITHUB_TOKEN

* Add automated changelog yaml from template for bot PR

* Delete Dependency-20220801-193810.yaml

* Add automated changelog yaml from template for bot PR

* remove dummy changelog

* remove token

* rename file

* point to main

Co-authored-by: Github Build Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-872] Move changie to reusable GHA
4 participants