Remove markupsafe pin #5507
Merged
Remove markupsafe pin #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
jtcohen6
reviewed
Jul 21, 2022
core/setup.py
Outdated
| @@ -49,7 +49,7 @@ | |||
| }, | |||
| install_requires=[ | |||
| "Jinja2==3.1.2", | |||
| "MarkupSafe>=0.23,<2.1", | |||
| "MarkupSafe>=2.0", | |||
There was a problem hiding this comment.
Any sense in just removing it entirely?
Reasoning:
- It's a second-order dependency of Jinja
- We didn't have it here until we needed to add the upper boundary earlier this year (Pin
MarkupSafe==2.0.1#4746) - We should move in the direction of minimal dependency specification in
setup.py, full dependency specification (exact versions tested + guaranteed to work) inrequirements.txt
jtcohen6
approved these changes
Jul 21, 2022
|
This missed the 1.2.1 dbt-core cutoff. Would be so nice if it could land in a near-term 1.2.2. |
|
@MichaelTiemannOSC unfortunately we will not be able to remove this pin for dbt versions previous to 1.3.0. In dbt-core 1.3.0 we were able to upgrade Jinja2 to version 3 which is what allowed the removal of the Markupsafe pin. You can see more information on the dependency conflicts between markupsafe and Jinja2 in the related issue. |
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* update markupsafe pin * add changelog * completely remove markupsafe pin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5506
Description
Remove pin of MarkUpSafe after Jinja2 upgrade.
Checklist
changie newto create a changelog entry