Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] add Optional node_color config in Docs dataclass #5343

Closed
wants to merge 2 commits into from

Conversation

matt-winkler
Copy link
Contributor

related to #5255

Description

Adds a configuration to allow custom node_color config in a docs block.

Checklist

@matt-winkler matt-winkler requested a review from a team as a code owner June 7, 2022 15:29
@matt-winkler matt-winkler requested a review from emmyoop June 7, 2022 15:29
@cla-bot cla-bot bot added the cla:yes label Jun 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@matt-winkler
Copy link
Contributor Author

matt-winkler commented Jun 7, 2022

Open questions:

  • Does this create a need to set default color configurations by node type? E.g. macros, seeds, tests, etc.

  • This will be just for models

  • Any impact from partial parsing behavior? From testing locally, I found that setting a default value in the Optional config block created mass changes to all node types

  • Identify any issues here from testing

  • Will this work with DAG-in-IDE for cloud?

  • Yes

@matt-winkler
Copy link
Contributor Author

@b-per You mentioned starting to take a stab at this. This update appears to work for setting a default docs dictionary within config.

However, when setting this from the dbt_project.yml, it only works when including the + syntax on the docs property. Otherwise, I get an unused configuration paths error. I'm missing something with how those properties from the project are parsed - can you help me out?

@b-per
Copy link
Contributor

b-per commented Jun 21, 2022

I have also created #5397 with docs configurable in dbt_project.yml.

@matt-winkler I am not 100% sure why the + is required before docs is a dictionary (this page mentions that this is the same for persist_docs)

@jtcohen6
Copy link
Contributor

Closing in favor of #5397 :)

@jtcohen6 jtcohen6 closed this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants