Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix postgres handling for unlimited varchars #5292

Merged
merged 4 commits into from
Aug 9, 2022
Merged

Fix postgres handling for unlimited varchars #5292

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7caad55
Fix postgres handling for unlimited varchars
shrodingers May 12, 2022
0b09596
fix: correctly name varchar
shrodingers May 23, 2022
9f27907
chore: added changelog entry
shrodingers May 23, 2022
d1b7528
Update .changes/unreleased/Fixes-20220523-103843.yaml
shrodingers Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changes/unreleased/Fixes-20220523-103843.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
kind: Fixes
body: Remove the default 256 characters limit on postgres character varying type when
no limitation is set
time: 2022-05-23T10:38:43.392232+02:00
custom:
Author: shrodingers
Issue: "636"
shrodingers marked this conversation as resolved.
Show resolved Hide resolved
PR: "5292"
6 changes: 4 additions & 2 deletions plugins/postgres/dbt/adapters/postgres/relation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ def relation_max_name_length(self):
class PostgresColumn(Column):
@property
def data_type(self):
# on postgres, do not convert 'text' to 'varchar()'
if self.dtype.lower() == "text":
# on postgres, do not convert 'text' or 'varchar' to 'varchar()'
if self.dtype.lower() == "text" or (
self.dtype.lower() == "character varying" and self.char_size is None
):
return self.dtype
return super().data_type