Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cli_vars instead of context to create package and selector renderers #4878

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Mar 16, 2022

resolves #4876

Description

Fix errors rendering vars in packages.yml and selectors.yml.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@gshank gshank requested a review from a team as a code owner March 16, 2022 18:50
@cla-bot cla-bot bot added the cla:yes label Mar 16, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@gshank gshank requested a review from a team as a code owner March 16, 2022 19:54
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-371] [Bug] CLI vars in packages.yml and selectors.yml don't work.
2 participants