Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changie fixes #4857

Merged
merged 8 commits into from
Mar 11, 2022
Merged

Small changie fixes #4857

merged 8 commits into from
Mar 11, 2022

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 11, 2022

resolves #4848

Description

  1. fixes broken links in the PR comment and changelog itself to point to our directions in the contributing docs on how to add a changelog.
  2. Comment that a changelog entry is required will only post once but GHA will continue to fail until the file is added.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@emmyoop emmyoop requested review from leahwicz and a team as code owners March 11, 2022 16:17
@cla-bot cla-bot bot added the cla:yes label Mar 11, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop added the backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch label Mar 11, 2022
@emmyoop emmyoop merged commit 0fce636 into main Mar 11, 2022
@emmyoop emmyoop deleted the er/ct341-changie-fixes branch March 11, 2022 20:54
@github-actions
Copy link
Contributor

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-4857-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 0fce63665cd8a45fbc069c02ae174e194ed5892b
# Push it to GitHub
git push --set-upstream origin backport-4857-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-4857-to-1.0.latest.

emmyoop added a commit that referenced this pull request Mar 11, 2022
* fix broken links, update GHA to not repost comment

* tweak GHA

* convert GHA used

* consolidate GHA

* fix PR numbers and pull comment as var

* fix name of workflow step

* changie merge to fix link at top of changelog

* add changelog yaml
# Conflicts:
#	CHANGELOG.md
emmyoop added a commit that referenced this pull request Mar 14, 2022
* fix broken links, update GHA to not repost comment

* tweak GHA

* convert GHA used

* consolidate GHA

* fix PR numbers and pull comment as var

* fix name of workflow step

* changie merge to fix link at top of changelog

* add changelog yaml
# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-341] Small changie fixes
2 participants