-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated index file to fix DAG errors for operations & work around null columns #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRs in
|
emmyoop
force-pushed
the
er/ct-50-doc-on-run-hook
branch
from
February 24, 2022 21:07
69b605b
to
46dc0af
Compare
emmyoop
changed the title
updated index file to fix DAG errors for operations
updated index file to fix DAG errors for operations & work around null columns
Feb 24, 2022
gshank
approved these changes
Feb 24, 2022
emmyoop
added
the
backport 1.0.latest
Tag for PR to be backported to the 1.0.latest branch
label
Feb 25, 2022
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-4763-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 673ad50e21ea33c9130b5626d8bbc0710949e235
# Push it to GitHub
git push --set-upstream origin backport-4763-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest Then, create a pull request where the |
emmyoop
added a commit
that referenced
this pull request
Feb 25, 2022
… around null columns (#4763) * updated index file to fix DAG errors for operations * update index file to reflect dbt-docs fixes * add changelog # Conflicts: # CHANGELOG.md
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4578
Description
This solves two separate and unrelated bugs.
Add operations so that parent/child map can be resolved. Also add the ability to view operations so the associated SQL can be viewed. Previously operations linked to no where and caused the DAG to not render.
Search results not filtering correctly in Databricks. This is actually a dbt-spark issue. This fix makes it so docs continue to work by checking for conditions that should never be true. Once the associated bug is resolved docs will continue to work as expected and will continue to work for all other adapters.
Checklist
CHANGELOG.md
and added information about my change