-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix deprecation firing for microbatch model w custom strategy #10989
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10989 +/- ##
==========================================
- Coverage 89.10% 89.05% -0.05%
==========================================
Files 183 183
Lines 23626 23626
==========================================
- Hits 21051 21040 -11
- Misses 2575 2586 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #10994
Problem
The deprecation about custom microbatch macros was being fired in the wrong instances. It was being fired a custom marcro wasn't present instead of when it was 🫠
Solution
Negate the conditional check of
self.manifest._microbatch_macro_is_core
Checklist