Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecation firing for microbatch model w custom strategy #10989

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Nov 12, 2024

Resolves #10994

Problem

The deprecation about custom microbatch macros was being fired in the wrong instances. It was being fired a custom marcro wasn't present instead of when it was 🫠

Solution

Negate the conditional check of self.manifest._microbatch_macro_is_core

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@MichelleArk MichelleArk requested a review from a team as a code owner November 12, 2024 20:07
@cla-bot cla-bot bot added the cla:yes label Nov 12, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (89caa33) to head (82a093a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10989      +/-   ##
==========================================
- Coverage   89.10%   89.05%   -0.05%     
==========================================
  Files         183      183              
  Lines       23626    23626              
==========================================
- Hits        21051    21040      -11     
- Misses       2575     2586      +11     
Flag Coverage Δ
integration 86.35% <100.00%> (-0.05%) ⬇️
unit 62.79% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.79% <0.00%> (ø)
Integration Tests 86.35% <100.00%> (-0.05%) ⬇️

dev-requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor Author

@MichelleArk MichelleArk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MichelleArk MichelleArk merged commit e9a2b54 into main Nov 13, 2024
59 of 60 checks passed
@MichelleArk MichelleArk deleted the fix-microbatch-deprecation branch November 13, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Deprecation warning for custom microbatch macros is being fired incorrectly
2 participants