Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception handling masking on cleanup (#997) #1000

Merged
merged 4 commits into from
Sep 18, 2018
Merged

Fix exception handling masking on cleanup (#997) #1000

merged 4 commits into from
Sep 18, 2018

Commits on Sep 18, 2018

  1. add extra logic around connection release in the finally block to avo… 

    …id raising during exception handling
    Jacob Beck committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    28ef796 View commit details
    Browse the repository at this point in the history

  2. fix an error where a non-string is passed to RuntimeException for a m… 

    …essage on python 2.7
    Jacob Beck committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    c58daa1 View commit details
    Browse the repository at this point in the history

  3. handle python 2 quirks

    Jacob Beck committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    fb97019 View commit details
    Browse the repository at this point in the history

  4. PR feedback

    Jacob Beck committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    22d4a1d View commit details
    Browse the repository at this point in the history