-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] fixtures in fixtures/subfolders throwing parsing error #9570
Closed
2 tasks done
Tracked by
#8283
Labels
bug
Something isn't working
High Severity
bug with significant impact that should be resolved in a reasonable timeframe
pre-release
Bug not yet in a stable release
unit tests
Issues related to built-in dbt unit testing functionality
Milestone
Comments
graciegoheen
added
bug
Something isn't working
pre-release
Bug not yet in a stable release
labels
Feb 13, 2024
graciegoheen
added
the
High Severity
bug with significant impact that should be resolved in a reasonable timeframe
label
Feb 13, 2024
slothkong
added a commit
to slothkong/dbt-core
that referenced
this issue
Feb 29, 2024
5 tasks
slothkong
added a commit
to slothkong/dbt-core
that referenced
this issue
Feb 29, 2024
…olders throwing parsing error
slothkong
added a commit
to slothkong/dbt-core
that referenced
this issue
Mar 6, 2024
* Transform skip_parsing (private variable of ManifestLoader.load()) into instance-attribute of ManifestLoader(), with default value False (to enable splitting of ManifestLoader.load()) * Split ManifestLoader.load(), to extract operation of PartialParsing into new method called ManifestLoader.safe_update_project_parser_files_partially() (to simplify both cognitive complexity in the codebase and mocking in unittestest) * Add "ignore" type-comments in new ManifestLoader.safe_update_project_parser_files_partially() (to silence mypy warnings regarding instance-attributes which can be initialized as None or as something else, e.g. self.saved_manifest)[1] [1] Although I wanted avoid "ignore" type-comments, it seems like addressing these mypy warnings in a stricter sense requires technical alignment and broader code changes. For example, might need to initialize self.saved_manifest as Manifest, instead of Optional[Manifest], so that PartialParsing gets inputs with type it currently expects. ... perhaps too far beyond the scope of this fix?
gshank
pushed a commit
that referenced
this issue
Mar 13, 2024
…9714) * [#9570] Fix fixtures in fixtures/subfolders throwing parsing error * Fast-forward imports to match upstream * Re-introduce doc strings on traceback info handling * [#9570] Changelog update for fix of fixtures in fixtures/subfolders throwing parsing error * [#9570] Improve testability and coverage for partial parsing * Transform skip_parsing (private variable of ManifestLoader.load()) into instance-attribute of ManifestLoader(), with default value False (to enable splitting of ManifestLoader.load()) * Split ManifestLoader.load(), to extract operation of PartialParsing into new method called ManifestLoader.safe_update_project_parser_files_partially() (to simplify both cognitive complexity in the codebase and mocking in unittestest) * Add "ignore" type-comments in new ManifestLoader.safe_update_project_parser_files_partially() (to silence mypy warnings regarding instance-attributes which can be initialized as None or as something else, e.g. self.saved_manifest)[1] [1] Although I wanted avoid "ignore" type-comments, it seems like addressing these mypy warnings in a stricter sense requires technical alignment and broader code changes. For example, might need to initialize self.saved_manifest as Manifest, instead of Optional[Manifest], so that PartialParsing gets inputs with type it currently expects. ... perhaps too far beyond the scope of this fix?
A pull request, #9714, fixed the secondary exception reported in this ticket, but not the primary error. |
Upon further investigation, this no longer seems to be an issue. Closing. |
dbeatty10
added
the
unit tests
Issues related to built-in dbt unit testing functionality
label
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
High Severity
bug with significant impact that should be resolved in a reasonable timeframe
pre-release
Bug not yet in a stable release
unit tests
Issues related to built-in dbt unit testing functionality
Is this a new bug in dbt-core?
Current Behavior
I have a unit test definition using csv fixtures:
Everything works as expected when I nest my fixture files directly in the fixtures folder:
fixtures/cloud_account_mappings_mock_output.csv
fixtures/cloud_account_mappings_mock_input.csv
If i instead nest my fixtures in a subfolder, I get a parsing error:
fixtures/cloud_account_mappings/cloud_account_mappings_mock_output.csv
fixtures/cloud_account_mappings/cloud_account_mappings_mock_input.csv
Expected Behavior
I should be able to nest my fixture files in subfolders for better repo organization
Which database adapter are you using with dbt?
snowflake
Additional Context
No response
The text was updated successfully, but these errors were encountered: