Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema tests for sources are added to the manifest twice. #3347

Closed
1 of 5 tasks
iknox-fa opened this issue May 12, 2021 · 0 comments · Fixed by #3880
Closed
1 of 5 tasks

Schema tests for sources are added to the manifest twice. #3347

iknox-fa opened this issue May 12, 2021 · 0 comments · Fixed by #3880
Labels
bug Something isn't working performance

Comments

@iknox-fa
Copy link
Contributor

Describe the bug

Tests that are applied to sources are added to the manifest twice. Once in the source patcher and once in the schema parser.

This wasn't caught before due to the early return in the exception method that should have been thrown when this occurs.

Steps To Reproduce

This behavior doesn't break functionality, however it's a performance hit and reduces our ability to throw helpful errors when duplicated tests are found.

To see what's actually happening start by commenting out lines noted in core/dbt/exceptions.py and run a dbt project that has tests applied to a source.

Expected behavior

dbt adds source tests to the manifest only once.

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt --version:

 0.20.0-b1

The operating system you're using:
macOS

The output of python --version:
Python 3.8.8

@iknox-fa iknox-fa added bug Something isn't working cli labels May 12, 2021
@jtcohen6 jtcohen6 added performance and removed cli labels May 12, 2021
jtcohen6 added a commit that referenced this issue Sep 14, 2021
jtcohen6 added a commit that referenced this issue Sep 22, 2021
jtcohen6 added a commit that referenced this issue Sep 22, 2021
jtcohen6 added a commit that referenced this issue Sep 26, 2021
jtcohen6 added a commit that referenced this issue Sep 30, 2021
* Fix #3347

* Rename data->singular, schema->generic

* Rm schema, data flag + tag behavior

* Update test FQNs, compiled paths

* Add changelog entry
iknox-fa pushed a commit that referenced this issue Feb 8, 2022
* Fix #3347

* Rename data->singular, schema->generic

* Rm schema, data flag + tag behavior

* Update test FQNs, compiled paths

* Add changelog entry

automatic commit by git-black, original commits:
  ca7c1fc
iknox-fa pushed a commit that referenced this issue Feb 8, 2022
* Fix #3347

* Rename data->singular, schema->generic

* Rm schema, data flag + tag behavior

* Update test FQNs, compiled paths

* Add changelog entry

automatic commit by git-black, original commits:
  a5ce658
  ca7c1fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants