-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema tests for sources are added to the manifest twice. #3347
Labels
Comments
4 tasks
jtcohen6
added a commit
that referenced
this issue
Sep 30, 2021
* Fix #3347 * Rename data->singular, schema->generic * Rm schema, data flag + tag behavior * Update test FQNs, compiled paths * Add changelog entry
iknox-fa
pushed a commit
that referenced
this issue
Feb 8, 2022
iknox-fa
pushed a commit
that referenced
this issue
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Tests that are applied to sources are added to the manifest twice. Once in the source patcher and once in the schema parser.
This wasn't caught before due to the early return in the exception method that should have been thrown when this occurs.
Steps To Reproduce
This behavior doesn't break functionality, however it's a performance hit and reduces our ability to throw helpful errors when duplicated tests are found.
To see what's actually happening start by commenting out lines noted in core/dbt/exceptions.py and run a dbt project that has tests applied to a source.
Expected behavior
dbt adds source tests to the manifest only once.
System information
Which database are you using dbt with?
The output of
dbt --version
:The operating system you're using:
macOS
The output of
python --version
:Python 3.8.8
The text was updated successfully, but these errors were encountered: