Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't validate profile for dbt clean #1022

Closed
drewbanin opened this issue Sep 21, 2018 · 0 comments
Closed

don't validate profile for dbt clean #1022

drewbanin opened this issue Sep 21, 2018 · 0 comments
Assignees
@beckjake
Labels
good_first_issue Straightforward + self-contained changes, good for new contributors!
Milestone
Guion Bluford

Comments

@drewbanin
Copy link
Contributor

Feature

Feature description

This issue #947 skips profile validation for the dbt deps command. That behavior should be extended to dbt clean as well.

The code change will probably happen around here: https://github.com/fishtown-analytics/dbt/blob/dev/guion-bluford/dbt/main.py#L210-L211
@drewbanin drewbanin added good_first_issue Straightforward + self-contained changes, good for new contributors! estimate: 1 labels Sep 21, 2018
@drewbanin drewbanin added this to the Guion Bluford milestone Sep 21, 2018
@cmcarthur cmcarthur assigned cmcarthur and beckjake and unassigned cmcarthur Sep 28, 2018
@beckjake beckjake mentioned this issue Sep 28, 2018
Merged
beckjake added a commit that referenced this issue Oct 1, 2018
@beckjake
Merge pull request #1038 from fishtown-analytics/fix/clean-without-pr…
42d6c9f 
…ofiles

make clean not require a profile (#1022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beckjake beckjake

Labels
good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Milestone
Guion Bluford
Development

No branches or pull requests
3 participants
@beckjake @cmcarthur @drewbanin