Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unset_contextvars to correctly unset the context vars #83

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Feb 22, 2024

resolves #82

Description

This is part of the fix for #dbt-core/8866, a problem with node_info persisting when it shouldn't.

Checklist

@gshank gshank requested a review from a team as a code owner February 22, 2024 01:04
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0d05e18) 52.23% compared to head (83fd7c5) 54.04%.

Files Patch % Lines
dbt_common/events/contextvars.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   52.23%   54.04%   +1.81%     
==========================================
  Files          49       49              
  Lines        2866     2866              
==========================================
+ Hits         1497     1549      +52     
+ Misses       1369     1317      -52     
Flag Coverage Δ
unit 54.04% <77.77%> (+1.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gshank gshank added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit 9a1f20a Feb 22, 2024
12 checks passed
@gshank gshank deleted the gs/fix_unset_contextvars branch February 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix unset_contextvars to unset the right contextvars
3 participants