Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mergeable to contract utils #59

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Add Mergeable to contract utils #59

merged 3 commits into from
Feb 1, 2024

Commits on Feb 1, 2024

  1. Add Mergeable to contract utils 

    At this moment in time, `Mergeable` is defined in core
[here](https://github.com/dbt-labs/dbt-core/blob/1a5d6922dddf9ffe018d8860bb2f2141594ddbbe/core/dbt/contracts/util.py#L27).
We're curren't in the process of moving data artifacts of nodes defined
in dbt-core's `nodes.py` into dbt-artifacts. Some of these data artifacts
depend on `Mergeable`. We don't want artifacts to depend on core, thus
`Mergeable` has to be moved _somewhere_ upstream. Given `Mergeable`'s
similarity to `Replaceable` it made the most sense to move next to
`Replaceable` here in dbt-common.
    @QMalcolm
    QMalcolm committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    7328934 View commit details
    Browse the repository at this point in the history

  2. Add changie doc for add mergeable

    @QMalcolm
    QMalcolm committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4f27dd4 View commit details
    Browse the repository at this point in the history

  3. Add unit test for newly added Mergeable class

    @QMalcolm
    QMalcolm committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    682b62c View commit details
    Browse the repository at this point in the history