-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADAP-1017: Fix configuration change monitoring for scenarios with no changes #1009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh my.
Feel free to merge assuming we don't need a if config_change_collection and config_change_collection.has_changes
style guard.
You know the method better than me, so act with that discretion.
Just to respond to this, |
@mikealfare @VersusFacit when do you expect to release it? |
Also waiting for this release 🙏 |
resolves #1007
Problem
Users cannot recreate a materialized view if it does not have any changes. The configuration change collection is not being recognized as an empty set of changes.
Solution
The check currently looks for the existence of the config change collection instead of whether it has any changes. Update the check to look for the existence of changes instead of the object itself.
Checklist