Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compare all columns tests #70

Merged
merged 6 commits into from
Mar 30, 2023
Merged

fix compare all columns tests #70

merged 6 commits into from
Mar 30, 2023

Conversation

leoebfolsom
Copy link
Contributor

@leoebfolsom leoebfolsom commented Mar 29, 2023 •
edited
Loading

Description & motivation

In my haste, I failed to consider that changing the Albertson's seed data would impact all the compare_all_columns tests.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@leoebfolsom leoebfolsom mentioned this pull request Mar 29, 2023
Closed
3 tasks
@joellabes joellabes merged commit 61e0d62 into dbt-labs:main Mar 30, 2023
@leoebfolsom leoebfolsom deleted the lf/fix-compare-all-columns-tests branch March 30, 2023 23:53
@leoebfolsom leoebfolsom mentioned this pull request Mar 31, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoebfolsom @joellabes