Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #55

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Update README #55

merged 2 commits into from
Nov 2, 2022

Conversation

wasilaq
Copy link
Contributor

@wasilaq wasilaq commented Oct 31, 2022

Description & motivation

Updated a single line in the README under the compare_relations macro. Folks should now use the summarize argument to see row-by-row mismatches, instead of tinkering with the compiled code.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@wasilaq wasilaq changed the title update README to reflect update in the compare_relations macro Update README Oct 31, 2022
@wasilaq wasilaq requested a review from joellabes October 31, 2022 18:19
joellabes
joellabes approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thank you @wasilaq!!

@joellabes joellabes merged commit 0634278 into main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wasilaq @joellabes