Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting current value of dbt_valid_to #321

Merged
merged 7 commits into from
Oct 10, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Sep 27, 2024

resolves #320

Problem

To support setting the snapshot dbt_valid_to column to a date value instead of null. For dbt-core dbt-labs/dbt-core#10780.

Solution

Use the setting of the new attribute "dbt_valid_to_current" instead of (or in addition to) null in various snapshot queries.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@gshank gshank merged commit 4df6e54 into main Oct 10, 2024
11 checks passed
@gshank gshank deleted the snapshot_dbt_valid_to_current branch October 10, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In snapshots, enable setting current value of dbt_valid_to
2 participants