-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1433] Add vertex retention to KeyedGrouping. #1470
Open
p-f
wants to merge
13
commits into
dbs-leipzig:develop
Choose a base branch
from
p-f:1433-keyedgrouping-retain
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change year in headers from 2020 to 2021. |
I did a few small benchmarks on the cluster. I was comparing:
Results:
Based on that result, the additional join is no problem. In the next few days i will commit a few documentation and style improvements. |
@timo95 for further commits, please add the issue number as prefix of your commit message ;) |
I am finished anyway 😃. You can review now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the feature to retain ungrouped vertices to
KeyedGrouping
.Description
Adds the feature as well as tests.
Related Issue
#1433
Motivation and Context
This was supported in the older grouping implementation, this is now also supported here.
How Has This Been Tested?
Reuses some old tests and adds new tests.
Types of Changes
Checklist: