Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divide gradoop-store integration- and unit-tests into separate test suites #1452

Open
Rascat opened this issue Nov 26, 2019 · 0 comments
Open

Divide gradoop-store integration- and unit-tests into separate test suites #1452

Rascat opened this issue Nov 26, 2019 · 0 comments

Comments

@Rascat
Copy link

Rascat commented Nov 26, 2019

Since the execution of integration tests in gradoop-store (e.g. org.gradoop.storage.impl.accumulo.basic.StoreTest) takes considerably more time than the unit tests, while also making our ci pipeline more brittle, we should separate the tests into two disjunctive test collections, unit and integration, and then probably only run the unit tests as part of our our ci pipeline.

both junit and testng support the definition of test suites so this might me a way to solve this problem.
Rascat pushed a commit to Rascat/gradoop that referenced this issue Nov 26, 2019
[dbs-leipzig#1452] Add junit test category 'IntegrationTests'
2b59dbf 
Adds a new interface 'IntegrationTests' to gradoop-accumulo.
This interface is used to categorize every test class in the
module. The category is excluded from surefire execution.
Rascat pushed a commit to Rascat/gradoop that referenced this issue Nov 26, 2019
[dbs-leipzig#1452] Assign every test in gradoop-hbase to group 'inter…
63042a8 
…gration or

'unit'
  * Create two testng suite xml files to run either of the new groups
  * Configure surefire to only run unit tests
Rascat pushed a commit to Rascat/gradoop that referenced this issue Dec 6, 2019
[dbs-leipzig#1452] configure test execution in gradoop-store
7de2e71 
  * Add default profile in gradoop-accumulo pom to control exection of
  integration tests
  * Add integration profile to gradoop-hbase pom
  * fix typo
Rascat pushed a commit to Rascat/gradoop that referenced this issue Dec 10, 2019
[dbs-leipzig#1452] Add javadoc to IntegrationTests interface
64ec7f4 
  * fix testng integration test suite name
@Rascat Rascat mentioned this issue Dec 10, 2019
Closed
8 tasks
Rascat pushed a commit to Rascat/gradoop that referenced this issue Dec 17, 2019
[dbs-leipzig#1452] Change test execution logic in module gradoop-hbase
4785dab 
  - Removes testng unit group (every test NOT belonging to the the
integration test group gets countet as unit test.
  - Removes unneeded testng xml suite files.
  - Adds new testng suite xml file "complete"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1452] gradoop store integration test suite Rascat/gradoop
1 participant
@Rascat