swapping the order of values when writing baseline #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, good catch! Thanks for the fix. |
|
Version 0.2.1 released. |
|
Thanks for the quick turnaround! And for the well written driver! |
Thanks 🙂 |
|
hi @slim-bean thanks for your interest! If you're curious as to why, the internal output is a stack (LIFO), but the input has to be processed on the fly. Swapping the output order would have taken up too much space - unfortunately we are that constrained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some issues reading/writing the baseline values on my sgp30 and found a small bug. It looks like Sensirion reversed the order of values between reading and writing the baseline.
When reading you get co2 then tvoc, but when writing they want tvoc then co2.
This PR fixes the ordering of the set_baseline command.