Skip to content
This repository has been archived by the owner on Aug 19, 2019. It is now read-only.

Add missing support for <s> tags for striketrough #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add missing support for <s> tags for striketrough #26

wants to merge 2 commits into from

Conversation

creynaud
Copy link

@creynaud creynaud commented Apr 18, 2017 •
edited
Loading

This change is split into 2 commits:

  • the 1st one is to replace strncmp calls by strcmp ones ("s" was falling into the "strong" if case)
  • the actual addition of "s" support

@creynaud
Prepare to add missing support for <s> tags
587822d 
<s> is also a tag that should be interpreted as strikethrough.

With strncmp, when a "s" tag is compared with "strong", it returns 0 because
only 1 character is compared -> use strcmp instead.
@creynaud
Add missing support for <s> tags for strikethrough
6737ff0
@creynaud
Copy link
Author

Hi,

Do you have any feedbacks on this pull request?

Thanks!
Claire

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@creynaud