-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBOSFailedSqlTransactionError #640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianl15
reviewed
Oct 7, 2024
qianl15
reviewed
Oct 7, 2024
src/workflow.ts
Outdated
this.resultBuffer.clear(); | ||
} catch (error) { | ||
if (this.#dbosExec.userDatabase.isFailedSqlTransactionError(error)) { | ||
this.logger.error(`Postgres aborted the ${txn.name} transaction of Workflow ${workflowUUID}. Something, such as a stored procedure, in the database caused the transaction to abort.`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
this.logger.error(`Postgres aborted the ${txn.name} transaction of Workflow ${workflowUUID}. Something, such as a stored procedure, in the database caused the transaction to abort.`); | |
this.logger.error(`Postgres aborted the ${txn.name} transaction of Workflow ${workflowUUID}, but the function did not raise an exception. Please ensure that if a transaction encounters an exception it raises an exception.`); |
qianl15
reviewed
Oct 9, 2024
src/workflow.ts
Outdated
this.resultBuffer.clear(); | ||
} catch (error) { | ||
if (this.#dbosExec.userDatabase.isFailedSqlTransactionError(error)) { | ||
this.logger.error(`Postgres aborted the ${txn.name} @Transaction of Workflow ${workflowUUID}, but the function did not raise an exception. Please ensure that if a transaction aborts from an exception, that exception is allowed to escape the @Transaction method.`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to emphasize that if a transaction aborts from an exception, we must raise an exception.
Suggested change
this.logger.error(`Postgres aborted the ${txn.name} @Transaction of Workflow ${workflowUUID}, but the function did not raise an exception. Please ensure that if a transaction aborts from an exception, that exception is allowed to escape the @Transaction method.`); | |
this.logger.error(`Postgres aborted the ${txn.name} @Transaction of Workflow ${workflowUUID}, but the function did not raise an exception. Please ensure that if a transaction aborts from an exception, it must raise an exception.`); |
qianl15
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
@Transaction
method invokes a user-authored stored procedure that raises an exception, the db transaction is aborted even if the exception is caught in the@Transaction
method. If the exception is caught and handled in the@transaction
method, DBOS will fail when it attempts to write the@Transaction
method return value to thetransaction_outputs
table because the associated db transaction has been aborted. This PR creates a DBOS specific error to throw in this situation.Fixes #626