Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled workflows #411

Merged
merged 59 commits into from
May 9, 2024
Merged

Scheduled workflows #411

merged 59 commits into from
May 9, 2024

Conversation

chuck-dbos
Copy link
Collaborator

No description provided.

tests/scheduler/scheduler.test.ts Outdated Show resolved Hide resolved
schemas/system_db_schema.ts Outdated Show resolved Hide resolved
src/dbos-executor.ts Outdated Show resolved Hide resolved
src/dbos-executor.ts Outdated Show resolved Hide resolved
src/dbos-executor.ts Outdated Show resolved Hide resolved
src/scheduler/scheduler.ts Outdated Show resolved Hide resolved
src/scheduler/scheduler.ts Outdated Show resolved Hide resolved
src/scheduler/scheduler.ts Outdated Show resolved Hide resolved
src/scheduler/scheduler.ts Outdated Show resolved Hide resolved
src/scheduler/scheduler.ts Outdated Show resolved Hide resolved
@chuck-dbos chuck-dbos marked this pull request as ready for review May 7, 2024 15:35
dbos-config.schema.json Outdated Show resolved Hide resolved
src/scheduler/scheduler.ts Outdated Show resolved Hide resolved
src/scheduler/scheduler.ts Outdated Show resolved Hide resolved
@qianl15
Copy link
Member

qianl15 commented May 9, 2024

Thanks! I like the current implementation. A nit is that registrationObject is no longer used anywhere in workflow config. Can we remove it for now? We can think about refactoring in a separate PR.

src/scheduler/scheduler.ts Outdated Show resolved Hide resolved
src/scheduler/scheduler.ts Outdated Show resolved Hide resolved
chuck-dbos and others added 2 commits May 9, 2024 14:46
Comment

Co-authored-by: Qian Li <[email protected]>
Signed-off-by: chuck-dbos <[email protected]>
Co-authored-by: Qian Li <[email protected]>
Signed-off-by: chuck-dbos <[email protected]>
@chuck-dbos chuck-dbos merged commit 4cd6c80 into main May 9, 2024
2 checks passed
@chuck-dbos chuck-dbos deleted the chuck/wfsched branch May 9, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants