Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Versions #134

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Dependency Versions #134

merged 2 commits into from
Oct 18, 2024

Conversation

kraftp
Copy link
Contributor

@kraftp kraftp commented Oct 18, 2024

Add compatibility with older versions of psycopg as newer versions don't support all Python installations.

Copy link
Contributor

@devhawk devhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update pdm.lock

@devhawk
Copy link
Contributor

devhawk commented Oct 18, 2024

From the github action run
image

@kraftp
Copy link
Contributor Author

kraftp commented Oct 18, 2024

From the github action run image

Yes, we're adding compatibility with old versions, not changing our dependency. Of course the new version is preferred, but now we work with the old version.

@devhawk
Copy link
Contributor

devhawk commented Oct 18, 2024

from https://pdm-project.org/en/latest/usage/lockfile

PDM installs packages exclusively from the existing lock file named pdm.lock. This file serves as the sole source of truth for installing dependencies.

@kraftp
Copy link
Contributor Author

kraftp commented Oct 18, 2024

from https://pdm-project.org/en/latest/usage/lockfile

PDM installs packages exclusively from the existing lock file named pdm.lock. This file serves as the sole source of truth for installing dependencies.

Sure, that's what PDM's local installation does, but the actual MANIFEST file distributed with the wheel is based off the dependencies in pyproject.toml.

@devhawk
Copy link
Contributor

devhawk commented Oct 18, 2024

Yes, we're adding compatibility with old versions, not changing our dependency. Of course the new version is preferred, but now we work with the old version.

AFAIK, changing the pyproject.toml file doesn't actually change anything if there's a pdm.lock file present.

@kraftp
Copy link
Contributor Author

kraftp commented Oct 18, 2024

Yes, we're adding compatibility with old versions, not changing our dependency. Of course the new version is preferred, but now we work with the old version.

AFAIK, changing the pyproject.toml file doesn't actually change anything if there's a pdm.lock file present.

Nope, the MANIFEST in the wheel is based off of pyproject.toml. Unpack the wheel and see for yourself :)

@kraftp kraftp merged commit 96e04e9 into main Oct 18, 2024
5 checks passed
@kraftp kraftp deleted the kraftp/versions branch October 18, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants