Fix passage building across more than two concatenated files (fixes #421) #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitzl
approved these changes
Apr 24, 2024
jbaiter
added a commit
that referenced
this pull request
Apr 25, 2024
**Changed:** - Missing files no longer fail the complete search request, instead the OCR highlighting for the document is skipped - Add support for Solr 9.5 - Updated documentation with warning for Solr 9 users to disable security sandboxing when using pointers to external files **Fixed:** - Regular highlighting in case no hl field can be determined works again (#404) - Passage building across more than two concatenated files works now (#422)
Merged
jbaiter
added a commit
that referenced
this pull request
Apr 25, 2024
**Changed:** - Missing files no longer fail the complete search request, instead the OCR highlighting for the document is skipped - Add support for Solr 9.5 - Updated documentation with warning for Solr 9 users to disable security sandboxing when using pointers to external files **Fixed:** - Regular highlighting in case no hl field can be determined works again (#404) - Passage building across more than two concatenated files works now (#422)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code previously only considered the case of two concatenated files when reading from a concatenated source pointer. This has now been fixed to allow an arbitrary number of files between the start and end offsets.