Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates to One Call 3.0 API #38

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Migrates to One Call 3.0 API #38

merged 4 commits into from
Jul 2, 2024

Conversation

jeanmartin
Copy link
Contributor

@jeanmartin jeanmartin commented Jun 30, 2024 •
edited
Loading

This doesn't take full advantage of all new One Call 3.0 features, but it adds the summary field to the daily response.

Addresses #37

@dblock
Copy link
Owner

dblock commented Jul 1, 2024 •
edited
Loading

Thanks!

Update CHANGELOG.

Increment version to 0.5.0 in this PR (version.rb, CHANGELOG, etc.), this is a major version change that breaks things.

@jeanmartin jeanmartin changed the title migrates to one_call 3.0 Migrates to One Call 3.0 API Jul 1, 2024
dblock
dblock requested changes Jul 1, 2024
View reviewed changes
Copy link
Owner

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danger is unhappy. Almost there. Thanks for hanging in here with me!

CHANGELOG.md Outdated Show resolved Hide resolved
dblock
dblock reviewed Jul 1, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jeanmartin jeanmartin requested a review from dblock July 1, 2024 19:37
@jeanmartin
Copy link
Contributor Author

No problem, Dangers happiness is important to me :D

@dblock dblock merged commit be6d875 into dblock:master Jul 2, 2024
8 checks passed
@dblock
Copy link
Owner

dblock commented Jul 2, 2024

Thanks, merged. I'll cut a release sometime sooner than later.

@dblock dblock mentioned this pull request Jul 2, 2024
Closed
@dblock
Copy link
Owner

dblock commented Sep 29, 2024

With this change I am seeing this in some logs:

WARN -- : Error getting weather at 50.06789, 19.92789 on 1727631664 for  ... Please note that using One Call 3.0 requires a separate subscription to the One Call by Call plan. Learn more here https://openweathermap.org/price. If you have a valid subscription to the One Call by Call plan, but still receive this error, then please see https://openweathermap.org/faq#error401 for more info..

So no more free lunch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanmartin @dblock