Exposed the national weather alerts response in the One Call API #25

troya2 · 2021-03-26T23:46:28Z

Added the feature, updated the relevant fixture, and added supporting specs.

Added national alerts section to VCR fixture. Added check for each alert field value.

dblock

Thanks! Made a bunch of comments, this is close.

dblock · 2021-03-27T13:44:31Z

CHANGELOG.md

@@ -2,6 +2,7 @@

 * [#21](https://github.com/dblock/open-weather-ruby-client/pull/21), [#20](https://github.com/dblock/open-weather-ruby-client/pull/20), [#19](https://github.com/dblock/open-weather-ruby-client/pull/19), [#18](https://github.com/dblock/open-weather-ruby-client/pull/18): Added support for Stations API - [@wasabigeek](https://github.com/wasabigeek).
 * [#22](https://github.com/dblock/open-weather-ruby-client/pull/23): Removed API version from `Config#endpoint` - [@dblock](https://github.com/dblock).
+* Exposed the national weather alerts response in the One Call API [@troya2](https://github.com/troya2)


Fix the format and danger will stop complaining. Missing a -, a period and a PR link in front.

dblock · 2021-03-27T13:45:22Z

lib/open_weather/models/one_call/alert.rb

+        property 'end', transform_with: ->(v) { Time.at(v).utc } # UTC
+        property 'description'
+
+        def initialize(args = nil, options = {})


You don't need to override the constructor unless you're doing something extra here. Just remove it.

dblock · 2021-03-27T13:46:48Z

spec/fixtures/open_weather/one_call/lat_lon.yml

@@ -95,7 +95,10 @@ http_interactions:
        rain","icon":"10d"}],"clouds":99,"rain":8.01,"uvi":10.95},{"dt":1589824800,"sunrise":1589800419,"sunset":1589850710,"temp":{"day":298.65,"min":289.07,"max":300.81,"night":289.49,"eve":297.92,"morn":289.07},"feels_like":{"day":298.14,"night":288.35,"eve":298.74,"morn":288.15},"pressure":1015,"humidity":56,"dew_point":289.47,"wind_speed":3.6,"wind_deg":21,"weather":[{"id":802,"main":"Clouds","description":"scattered
        clouds","icon":"03d"}],"clouds":49,"uvi":10.91},{"dt":1589911200,"sunrise":1589886783,"sunset":1589937154,"temp":{"day":296.27,"min":286.83,"max":298.28,"night":288.9,"eve":297.35,"morn":286.83},"feels_like":{"day":295.57,"night":288.28,"eve":299.19,"morn":286.03},"pressure":1015,"humidity":56,"dew_point":287.09,"wind_speed":2.73,"wind_deg":40,"weather":[{"id":800,"main":"Clear","description":"clear
        sky","icon":"01d"}],"clouds":0,"uvi":10.01},{"dt":1589997600,"sunrise":1589973148,"sunset":1590023597,"temp":{"day":298.21,"min":287.71,"max":299.71,"night":290.03,"eve":298.59,"morn":287.71},"feels_like":{"day":299.68,"night":289.89,"eve":301.62,"morn":287.74},"pressure":1014,"humidity":61,"dew_point":290.18,"wind_speed":1.3,"wind_deg":71,"weather":[{"id":800,"main":"Clear","description":"clear
-        sky","icon":"01d"}],"clouds":0,"uvi":10.16}]}'
+        sky","icon":"01d"}],"clouds":0,"uvi":10.16}],"alerts": [{"sender_name": "NWS Tulsa (Eastern Oklahoma)","event": "Heat Advisory","start": 1597341600,"end": 1597366800,"description": "...HEAT ADVISORY REMAINS IN EFFECT FROM 1 PM THIS AFTERNOON TO\n8 PM CDT THIS EVENING...\n* WHAT...Heat index values of 105 to 109 degrees expected.\n* WHERE...Creek, Okfuskee, Okmulgee, McIntosh, Pittsburg,\nLatimer, Pushmataha, and Choctaw Counties.\n* WHEN...From 1 PM to 8 PM CDT Thursday.\n* IMPACTS...The combination of hot temperatures and high\nhumidity will combine to create a dangerous situation in which\nheat illnesses are possible."}]}'


We usually don't hand-craft VCR-recorded data. You should record a new separate VCR K7 .yml that has alerts data and write a separate unit test for that.

spec/open_weather/one_call/one_call_spec.rb

dblock · 2023-12-28T14:13:57Z

Any interest in finishing this @troya2?

troya2 · 2023-12-31T22:33:16Z

@dblock Thanks for the prod - looking at it now. I haven't used VCR, so I'll have to work on that. The other items are easy. Committing them now.

…nd updated expectations to match.

troya2 · 2023-12-31T23:32:05Z

@dblock I believe I've resolved all of your comments. Let me know if not. Happy new year!

dblock

CHANGELOG is in the wrong place, the rest looks good!

dblock · 2024-01-01T00:01:35Z

CHANGELOG.md

@@ -12,6 +12,8 @@
 * [#27](https://github.com/dblock/open-weather-ruby-client/pull/27): Removed default values for Faraday’s SSL settings ca_file and ca_path - [@sunny](https://github.com/sunny).
 * [#21](https://github.com/dblock/open-weather-ruby-client/pull/21), [#20](https://github.com/dblock/open-weather-ruby-client/pull/20), [#19](https://github.com/dblock/open-weather-ruby-client/pull/19), [#18](https://github.com/dblock/open-weather-ruby-client/pull/18): Added support for Stations API - [@wasabigeek](https://github.com/wasabigeek).
 * [#22](https://github.com/dblock/open-weather-ruby-client/pull/23): Removed API version from `Config#endpoint` - [@dblock](https://github.com/dblock).
+* [#25](https://github.com/dblock/open-weather-ruby-client/pull/25): Exposed the national weather alerts response in the One Call API [@troya2](https://github.com/troya2).


This should go to the 0.4.1 next release above, please. Rebase.

dblock · 2024-01-01T00:03:02Z

spec/open_weather/one_call/one_call_spec.rb

+
+    # Alerts
+    expect(data.alerts.first).to be_a OpenWeather::Models::OneCall::Alert
+    expect(data.alerts.first.sender_name).to eq 'NWS Phoenix (Central Arizona and California Desert)'


Nitpicking, but we could do this, which may be slightly more elegant.

data.alerts.first.tap do |alert| expect(alert).to be_a expect(alert.sender_name).to eq ... end

Added national alerts section to VCR fixture. Added check for each alert field value.

…nd updated expectations to match.

…nt into alerts

dblock · 2024-01-02T16:39:52Z

Thanks for finishing this up! Want to help with co-maintenance of this gem? Make the next release? Drop me a note to dblock at dblock dot org with your rubygems username if yes.

troya2 added 3 commits March 26, 2021 16:15

Added alerts to the one_call API response.

ce964b1

Update change log and readme.

9e21ab6

Added alerts to the one_call spec

5c434d8

Added national alerts section to VCR fixture. Added check for each alert field value.

dblock reviewed Mar 27, 2021

View reviewed changes

troya2 added 2 commits December 31, 2023 15:34

Fixed formatting in CHANGELOG and removed superfluous Alert constructor.

fe9321c

Rerecorded the lat_lon spec with a location that has current alerts a…

c596d08

…nd updated expectations to match.

Merge branch 'master' into alerts

b084339

dblock requested changes Jan 1, 2024

View reviewed changes

troya2 added 8 commits January 1, 2024 16:10

Added alerts to the one_call API response.

8f713f9

Update change log and readme.

1e3b6e5

Added alerts to the one_call spec

9c2c71e

Added national alerts section to VCR fixture. Added check for each alert field value.

Fixed formatting in CHANGELOG and removed superfluous Alert constructor.

46f4c4c

Rerecorded the lat_lon spec with a location that has current alerts a…

bab735b

…nd updated expectations to match.

Merge branch 'alerts' of github.com:alliedcode/open-weather-ruby-clie…

6be27da

…nt into alerts

Removed extra change long entry

6e7fd9d

DRY'd up alert spec a bit.

672b548

dblock merged commit d82ac09 into dblock:master Jan 2, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exposed the national weather alerts response in the One Call API #25

Exposed the national weather alerts response in the One Call API #25

troya2 commented Mar 26, 2021

dblock left a comment

dblock Mar 27, 2021

dblock Mar 27, 2021

dblock Mar 27, 2021

dblock commented Dec 28, 2023

troya2 commented Dec 31, 2023

troya2 commented Dec 31, 2023

dblock left a comment

dblock Jan 1, 2024

dblock Jan 1, 2024

dblock commented Jan 2, 2024

Exposed the national weather alerts response in the One Call API #25

Exposed the national weather alerts response in the One Call API #25

Conversation

troya2 commented Mar 26, 2021

dblock left a comment

Choose a reason for hiding this comment

dblock Mar 27, 2021

Choose a reason for hiding this comment

dblock Mar 27, 2021

Choose a reason for hiding this comment

dblock Mar 27, 2021

Choose a reason for hiding this comment

dblock commented Dec 28, 2023

troya2 commented Dec 31, 2023

troya2 commented Dec 31, 2023

dblock left a comment

Choose a reason for hiding this comment

dblock Jan 1, 2024

Choose a reason for hiding this comment

dblock Jan 1, 2024

Choose a reason for hiding this comment

dblock commented Jan 2, 2024