Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with configuration description; #25

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

Antondomashnev
Copy link
Collaborator

Just an update in README.md about new way to configure the plugin.

@Antondomashnev Antondomashnev requested a review from dblock March 29, 2017 14:36
@@ -3,7 +3,8 @@
### 0.3.0 (Next)

* Your contribution here.
* [#20](https://github.com/dblock/danger-changelog/pull/21): Added support for custom '* Your contribution here.' line - [@antondomashnev](https://github.com/antondomashnev).
* [#25](https://github.com/dblock/danger-changelog/pull/25): Add information how to configure the plugin in README.md - [@antondomashnev](https://github.com/antondomashnev).
Copy link
Owner

@dblock dblock Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically I don't include README updates in CHANGELOG, but nbd.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense, but we don't have any check in Danger to skip readme changes, do we?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a feature request ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already have one #6

@dblock dblock merged commit cc325df into dblock:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants