-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customization of placeholder line; #24
Add customization of placeholder line; #24
Conversation
I like where it's going, but maybe it's overly complicated? Is there any way to have more than one of these configurations? I don't think so, so I would just create a global configuration object ala https://github.com/slack-ruby/slack-ruby-client/blob/master/lib/slack/config.rb and call it a day. Then we can do |
@dblock was one of the ideas as well, I think you're right would be clearer and we don't need multiple configurations. I'll update the PR with that approach. |
…because of addiitional parameter in is_changelog_format_correct?;
@dblock check out the updated PR, it looks much better now, thanks for your suggestion - every day we learn 😄 |
@dblock the Travis CI is failing and it seems because of the rubocop's new version. Is there a reason to keep the |
Since Gemfile.lock isn't committed rubocop should be locked at a specific version. I usually run |
Perfect, merging. |
Hi @dblock this PR addresses the #11 issue. I've started with configuration object which could eventually help to resolve multiple issues easier. Let me know what you think about implementation.