Merge main into network gen branch #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* run doctests on quick_check * update documentation workflow to test documentation building on pull requests.
Update the quick_check to no longer fast-fail.
* define sample_raster * adding module check in sample_raster * exposing sample_raster to wntr.gis interface * add test for sample_raster * trivial whitespace commit to re-run actions * adding rasterio to optional requirement * added tif to gitignore * updated docs for rasterio * clean up for raster functionality * update test to use net1. add user manual documentation. figure and data added for raster example * adjusting test to produce a smaller tiff file. * small updates to user docs * rename datafile * update test to include tanks * update gis to include tanks, add elevations to model, and mention hazard datasets. Figure filename changed. * cleanup test * adding documentation updates --------- Co-authored-by: kaklise <[email protected]>
* bug fix, missing commas in _base_attributes * Updates to remove the use of node_type and link_type in WaterNetworkGIS GeoDataFrames * updated/added tests * removed user tests, geodataframes no longer store node_type * Added "name" back into the list of valid gis columns, updated tests * updated documentation * minor updates --------- Co-authored-by: kbonney <[email protected]>
* Added D-W conversion for roughness coefficient for inp file i/o * bug fix in roughness conversion * Added a warning if the user changes headloss to/from D-W * Added additional tests for changing headloss formula * Updated test * commented out graphics in test
…om gis (#447) * Add ability to input single demand from giw/dict * Add test * update doctests to account for column name changes * change default return in junction properties to reflect default values in add_junction * fix doctests * move demand attributes from optional to base. fix docstest accordingly * fix doctest * fix doctest by adding sort to column name list * rewrite portions of IO documentation for clarity * add cross references for methods --------- Co-authored-by: Angus <[email protected]> Co-authored-by: kbonney <[email protected]>
dbhart
added a commit
that referenced
this pull request
Dec 16, 2024
Merge main into network gen branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.